feat: Mac UI app to match global log level - #2139
Draft
adrien-coye wants to merge 2 commits into
Draft
adrien-coye wants to merge 2 commits into
adrien-coye wants to merge 2 commits into
Conversation
# Conflicts: # src/gui4/macOS/kDriveCore/ServerBridge/Cache/SettingsCache.swift # src/gui4/macOS/kDriveCore/Utils/UserDefaults+Extension.swift
adrien-coye
force-pushed
the
fix/ui-match-global-log-level
branch
from
August 12, 2026 08:23
cda1937 to
f6e31e7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Synchronizes macOS file logging with the server-provided log level.
Changes:
- Maps server log levels to Swift logging levels.
- Persists and dynamically applies the minimum file log level.
- Adds mapping, persistence, and runtime filtering tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
LogServiceTests.swift |
Tests runtime filtering changes. |
LogLevelKDCMappingTests.swift |
Tests server-level mapping. |
SettingsCacheTests.swift |
Tests level persistence. |
UserDefaults+Extension.swift |
Stores the last known level. |
SettingsCache.swift |
Applies server logging settings. |
LogService.swift |
Supports runtime threshold updates. |
LogLevel+KDC.swift |
Maps KDC log levels. |
project.pbxproj |
Registers the new test file. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+68
to
+71
| let fileLogLevel = LogLevel(kdcLogLevel: settings.logLevel) | ||
| UserDefaults.standard.lastKnownFileLogLevel = fileLogLevel | ||
| @InjectService var logService: LogService | ||
| logService.setMinimumFileLevel(fileLogLevel) |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged for the release to public version