feat: Dynamic island review

[adrien-coye]

No description provided.

[Copilot]

Pull request overview

This PR refactors the Dynamic Island upload integration to be concurrency-safe by moving the Dynamic Island service to an actor, making the service protocol async/Sendable, and extracting upload progress tracking into a dedicated tracker object.

Changes:

• Convert DynamicIslandServiceable APIs to async and update call sites to await them.
• Replace DynamicIslandManager with DynamicIslandUploadProgressTracker and adjust DI wiring.
• Rework DynamicIslandService execution flow around continuations and progress updates.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
kDriveTests/kDrive/Launch/UTRootViewControllerState.swift	Updates test DI registrations to use DynamicIslandUploadProgressTracker instead of the previous manager.
kDriveCore/DI/CoreTargetAssembly.swift	Updates core DI registrations for the Dynamic Island tracker and provides BGTaskScheduler.shared.
kDriveCore/Data/Upload/UploadQueue/Operation/UploadOperation+Error.swift	Wraps Dynamic Island cancellation calls in Task { await ... } to match async service APIs.
kDriveCore/Data/Upload/Servicies/UploadService/Parallelism/UploadParallelismOrchestrator.swift	Wraps queue activity updates in a task to call the async Dynamic Island API.
kDriveCore/Data/Upload/Servicies/DynamicIslandServiceable.swift	Makes the Dynamic Island service protocol Sendable and all methods async.
kDriveCore/Data/Upload/Servicies/DynamicIslandService.swift	Converts the service to an actor, injects BGTaskScheduler, and updates progress/title handling logic.
kDriveCore/Data/Upload/DynamicIslandUploadProgressTracker.swift	Renames/extracts progress tracking into DynamicIslandUploadProgressTracker, adds async snapshot/reset helpers.
kDrive/AppDelegate.swift	Calls registerTask() via Task { await ... } to match the new async API.

Comments suppressed due to low confidence (1)

kDriveCore/Data/Upload/Servicies/DynamicIslandService.swift:103

• updateQueueActivity(globalQueueActive:photoQueueActive:) is async in the protocol, but implemented synchronously here. After making it async, the internal call to submitTask() also needs to be awaited.

    public func updateQueueActivity(globalQueueActive: Bool, photoQueueActive: Bool) {
        uploadProgressTracker.updateQueueActivity(
            globalQueueActive: globalQueueActive,
            photoQueueActive: photoQueueActive
        )

        if globalQueueActive || photoQueueActive {
            submitTask()
        }
    }

[sonarqubecloud]

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud