feat: Allow modules to compile on macOS - #326
Merged
Merged
Conversation
LouisCAD
requested changes
Sep 14, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The macOS dependency matches the configured target and existing iOS implementation.
Pull request overview
Adds the Ktor Darwin engine required for STNetwork to compile and run on macOS.
Changes:
- Adds
ktor-client-darwintomacosMain.
File summaries
| File | Description |
|---|---|
STNetwork/build.gradle.kts |
Configures the macOS Ktor client engine dependency. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
baillyjamy
approved these changes
Sep 14, 2026
PhilippeWeidmann
force-pushed
the
feat/macos-target
branch
from
September 14, 2026 14:11
fe8e9fa to
79f45b9
Compare
|
LouisCAD
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.