feat: Delete by scope - #162
Open
benjaminVadon wants to merge 6 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benjaminVadon
changed the base branch from
main
to
recurrence-state-and-edit-scopes
September 11, 2026 14:21
|
This PR/issue depends on:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
RDATE-only series can be deleted incorrectly, alarm preservation is lossy, and dense series can exceed expansion limits.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds scoped deletion for recurring event occurrences.
Changes:
- Exposes occurrence-aware deletion through
CalendarManager. - Implements EXDATE-based deletion and recurrence truncation.
- Adds repository tests for deletion scopes.
File summaries
| File | Description |
|---|---|
EventRepositoryTest.kt |
Tests scoped deletion behavior. |
CalendarManager.kt |
Exposes the public deletion API. |
RecurringEventExpansion.kt |
Converts recurrence keys to iCalendar values. |
RecurrenceTruncation.kt |
Truncates recurrence rules before a pivot. |
EventRepository.kt |
Implements each deletion scope. |
EventEntityToEditData.kt |
Reconstructs edit data for recurrence patches. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #160