feat: Keep unknown-action alarms uneditable - #180
Open
benjaminVadon wants to merge 1 commit into
Open
benjaminVadon wants to merge 1 commit into
benjaminVadon wants to merge 1 commit into
Conversation
benjaminVadon
force-pushed
the
keep-unknown-alarms-uneditable
branch
3 times, most recently
from
September 24, 2026 08:29
44efbc6 to
bf4c40f
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
benjaminVadon
force-pushed
the
keep-unknown-alarms-uneditable
branch
from
September 24, 2026 10:22
bf4c40f to
6322bda
Compare
|
benjaminVadon
requested review from
sirambd
and
a balanced review from Copilot
September 24, 2026 13:06
Comment on lines
+71
to
+72
| if action.is_none() { | ||
| *action = action_value(marker); |
| action.map_or(true, |action| EDITABLE_ACTIONS.iter().any(|editable| action.eq_ignore_ascii_case(editable))) | ||
| } | ||
|
|
||
| /// A VALARM no edit may drop, see [`EDITABLE_ACTIONS`]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.