Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The implementation also trims user-authored whitespace outside marked blocks.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds cleanedDescription to expose event descriptions without Infomaniak-marked blocks.
Changes:
- Adds marked-block removal logic.
- Exposes cleaned descriptions on
Event. - Adds tests for block-removal scenarios.
| File | Description |
|---|---|
EventDescriptionExtensions.kt |
Implements marked-block removal. |
Event.kt |
Adds the cleanedDescription property. |
EventDescriptionExtensionsTest.kt |
Tests block-removal behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
Event.cleanedDescriptionproperty, which returns the event description with Infomaniak-marked blocks removed.Includes tests for single and multiple blocks, empty blocks, and blocks containing line breaks.