feat: add videos page(s)#72
Open
bartoostveen wants to merge 4 commits into
Open
Conversation
Open
SimplyPancake
approved these changes
Apr 13, 2026
Contributor
|
Conflicts! |
bartoostveen
force-pushed
the
31-add-a-videos-tab
branch
3 times, most recently
from
c317051 to
b34ad15
Compare
Member
Author
|
That went very smoothly. |
Member
Author
|
Fixes #77 |
Member
Author
|
The tests do not pass as Inter-Actief/amelie#1205 requires to be merged first. |
Member
Author
|
Kicked off a rerun of all checks, let's see if my commit reached staging yet... |
Member
Author
|
Works on my machine, I might have to update the yarn lockfile as someone forgot to do that in another commit :( Edit: apparently we got rid of lucide icons, and testing if merged on top of main goes wrong? I am rebasing :p |
This requires Inter-Actief/amelie#1205 to be merged.
This finalizes rebasing on main once again
bartoostveen
force-pushed
the
31-add-a-videos-tab
branch
from
5c77495 to
1bbb1a0
Compare
Member
Author
|
Rebased on main :) |
SimplyPancake
requested changes
May 12, 2026
Contributor
SimplyPancake
left a comment
SimplyPancake
left a comment
There was a problem hiding this comment.
Looks good! Only thing I'd suggest is a placeholder image if there is no preview (Some videos I didn't see a preview for)
Member
Author
|
IMHO that is #65 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe what your PR is fixing
This PR drafts an intial design for the video's page.
Blocked by Inter-Actief/amelie#1205
Concretely, which issues does your PR solve? (Please reference them by typing
Fixes/References Inter-Actief/amelink#<issue_id>)Closes #31, #77
Does your PR change how we process personal data, impact our privacy document, or modify (one of) our data export(s)?
no
Does your PR include any updates of packages?
no
Does your PR include the proper translations (did you add translations for new/modified strings)?
If so, did you also run
yarn gettext:extract?yes, I have included the translations
Does your PR change routing?
yes
Did your PR include a modification of the environment variables (and did you include the correct types in .env.d.ts ?)
yes
Did you properly test your PR before submitting it?
yes