Remove ProtocolParametersUpdate#1103

Draft

Jimbo4350 wants to merge 2 commits intomasterfrom

jordan/remove-ProtocolParametersUpdate

Contributor

Jimbo4350 commented Feb 6, 2026 •

edited

Loading

Changelog

- description: |
    Remove deprecated `ProtocolParametersUpdate` type and associated conversion functions
    (`toLedgerUpdate`, `toLedgerProposedPPUpdates`, `fromLedgerProposedPPUpdates`,
    `toLedgerPParamsUpdate`, `fromLedgerPParamsUpdate`).
    Remove `makeShelleyTransactionBody` and accompanying internal functions.
  type:
    - breaking
    - refactoring
  projects:
    - cardano-api

Context

Removes deprecated code that has been superseded by era-based protocol parameter updates. This cleans up ProtocolParameters.hs and Tx.Internal.Body significantly (~1000 lines removed).

How to trust this PR

Straightforward removal of deprecated, unused code. Build passes cleanly.

Checklist

Commit sequence broadly makes sense and commits have useful messages
New tests are added if needed and existing tests are updated
Self-reviewed the diff

github-advanced-security bot found potential problems

View reviewed changes

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs

		@@ -0,0 +1,71 @@
		{-# LANGUAGE DataKinds #-}
		{-# LANGUAGE EmptyCase #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning generated

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs:2:1-26: Warning: Unused LANGUAGE pragma

Found:
  {-# LANGUAGE EmptyCase #-}

Perhaps you should remove it.

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs

+              {-# LANGUAGE EmptyCase #-}
+              {-# LANGUAGE FlexibleContexts #-}
+              {-# LANGUAGE GADTs #-}
+              {-# LANGUAGE NamedFieldPuns #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning generated

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs:5:1-31: Warning: Unused LANGUAGE pragma

Found:
  {-# LANGUAGE NamedFieldPuns #-}

Perhaps you should remove it.

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs

+              {-# LANGUAGE FlexibleContexts #-}
+              {-# LANGUAGE GADTs #-}
+              {-# LANGUAGE NamedFieldPuns #-}
+              {-# LANGUAGE OverloadedStrings #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning generated

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs:6:1-34: Warning: Unused LANGUAGE pragma

Found:
  {-# LANGUAGE OverloadedStrings #-}

Perhaps you should remove it.

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs

+              {-# LANGUAGE NamedFieldPuns #-}
+              {-# LANGUAGE OverloadedStrings #-}
+              {-# LANGUAGE RankNTypes #-}
+              {-# LANGUAGE RecordWildCards #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning generated

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs:8:1-32: Warning: Unused LANGUAGE pragma

Found:
  {-# LANGUAGE RecordWildCards #-}

Perhaps you should remove it.

Note: may require {-# LANGUAGE DisambiguateRecordFields #-} adding to the top of the file

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs

+              {-# LANGUAGE RankNTypes #-}
+              {-# LANGUAGE RecordWildCards #-}
+              {-# LANGUAGE ScopedTypeVariables #-}
+              {-# LANGUAGE TupleSections #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning generated

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs:10:1-30: Warning: Unused LANGUAGE pragma

Found:
  {-# LANGUAGE TupleSections #-}

Perhaps you should remove it.

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs

+              {-# LANGUAGE RecordWildCards #-}
+              {-# LANGUAGE ScopedTypeVariables #-}
+              {-# LANGUAGE TupleSections #-}
+              {-# LANGUAGE TypeApplications #-}

Check warning

Code scanning / HLint

Unused LANGUAGE pragma Warning generated

cardano-api/gen/Test/Gen/Cardano/Api/Internal/Shared.hs:11:1-33: Warning: Unused LANGUAGE pragma

Found:
  {-# LANGUAGE TypeApplications #-}

Perhaps you should remove it.

Jimbo4350 force-pushed the jordan/remove-ProtocolParametersUpdate branch 2 times, most recently from 0d214de to 3686dc7 Compare

February 12, 2026 12:15

Jimbo4350 force-pushed the jordan/remove-ProtocolParametersUpdate branch from 3686dc7 to 0cb8e81 Compare

March 12, 2026 14:41

Contributor Author

Jimbo4350 commented Mar 19, 2026

⚠️ Do not merge until node version 11 is released.

Jimbo4350 force-pushed the jordan/remove-ProtocolParametersUpdate branch 3 times, most recently from dc4394a to 8056c64 Compare

March 23, 2026 16:17

Jimbo4350 added 2 commits

March 24, 2026 12:38


          Remove makeShelleyTransactionBody and accompanying functions

7df9457


          Remove deprecated ProtocolParametersUpdate type and associated conver…

48922cd

…sion functions

Jimbo4350 force-pushed the jordan/remove-ProtocolParametersUpdate branch from 8056c64 to 48922cd Compare

March 24, 2026 17:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dcoutts Awaiting requested review from dcoutts dcoutts will be requested when the pull request is marked ready for review dcoutts is a code owner

erikd Awaiting requested review from erikd erikd will be requested when the pull request is marked ready for review erikd is a code owner

newhoggy Awaiting requested review from newhoggy newhoggy will be requested when the pull request is marked ready for review newhoggy is a code owner

carbolymer Awaiting requested review from carbolymer carbolymer will be requested when the pull request is marked ready for review carbolymer is a code owner

palas Awaiting requested review from palas palas will be requested when the pull request is marked ready for review palas is a code owner

kevinhammond Awaiting requested review from kevinhammond kevinhammond will be requested when the pull request is marked ready for review kevinhammond is a code owner

CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara will be requested when the pull request is marked ready for review CarlosLopezDeLara is a code owner

disassembler Awaiting requested review from disassembler disassembler will be requested when the pull request is marked ready for review disassembler is a code owner

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Labels

None yet