-
Notifications
You must be signed in to change notification settings - Fork 24
feat(client): replace NetworkId with Chain descriptor #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
solidsnakedev
wants to merge
8
commits into
main
Choose a base branch
from
feat/chain-interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ca54a58
feat(client): replace NetworkId with Chain descriptor
solidsnakedev a25cb01
feat(devnet): add getChain and BOOTSTRAP_CHAIN helpers
solidsnakedev 342da47
chore(example): migrate to chain: Chain pattern
solidsnakedev 3866c80
docs(clients): update chain configuration examples
solidsnakedev c5abca1
release: changeset for chain-interface
solidsnakedev 80d7339
fix: migrate docs and devnet tests to Chain interface
solidsnakedev 7422aaa
fix: align blockfrost URL fallback with chain fallback
solidsnakedev a97ee5a
docs: migrate all network references to chain API
solidsnakedev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| --- | ||
| "@evolution-sdk/evolution": patch | ||
| "@evolution-sdk/devnet": patch | ||
| --- | ||
|
|
||
| `createClient` now requires an explicit `chain` field instead of the optional `network?: string` field. | ||
|
|
||
| Previously, selecting a network required passing a string identifier and, separately, a `slotConfig` object for slot/time conversions. There was no single source of truth that tied network identity, magic number, and timing parameters together: | ||
|
|
||
| ```ts | ||
| // Before | ||
| createClient({ | ||
| network: "preprod", | ||
| slotConfig: { zeroTime: 1655769600000n, zeroSlot: 86400n, slotLength: 1000 }, | ||
| provider: { ... }, | ||
| wallet: { ... } | ||
| }) | ||
| ``` | ||
|
|
||
| Now the `chain` field is a rich descriptor that carries all of this together. Three built-in constants are exported from the top-level package: | ||
|
|
||
| ```ts | ||
| // After | ||
| import { createClient, preprod } from "@evolution-sdk/evolution" | ||
|
|
||
| createClient({ | ||
| chain: preprod, | ||
| provider: { ... }, | ||
| wallet: { ... } | ||
| }) | ||
| ``` | ||
|
|
||
| For custom networks — local devnets, private chains, or future forks — use `defineChain`: | ||
|
|
||
| ```ts | ||
| import { defineChain } from "@evolution-sdk/evolution" | ||
|
|
||
| const devnet = defineChain({ | ||
| name: "Devnet", | ||
| id: 0, | ||
| networkMagic: 42, | ||
| slotConfig: { zeroTime: 0n, zeroSlot: 0n, slotLength: 1000 }, | ||
| epochLength: 432000, | ||
| }) | ||
| ``` | ||
|
|
||
| The `networkId: number | string` property on client objects is replaced with `chain: Chain`. The `@evolution-sdk/devnet` package adds `getChain(cluster)` and `BOOTSTRAP_CHAIN` for constructing a `Chain` from a running local devnet. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changeset marks the release as a patch, but replacing
network?: NetworkIdwith requiredchain: Chain(and removingcreateClient()/ default-network behavior) is a breaking public API change. The changeset should be a major bump (or at least follow the repo’s documented semver policy for breaking changes).