fix: types フィールドの拡張子を .d.ts へ修正する (0.3.1)#17
Merged
Conversation
types が存在しない ./cjs/index.d.js (.d.js 拡張子) を指していたため、
bare import (例: import { Cookie } from '@intimatemerger-internal/im-core')
の型解決が効かず any にフォールバックしていた。実在する
./cjs/index.d.ts を指すよう修正し、version を 0.3.1 へ上げる。
subpath import (例: .../im-core/esm/XHR) は各自の .d.ts を直接解決する
ため本 typo の影響は受けない。
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
package.jsonのtypesフィールドが存在しない拡張子./cjs/index.d.js(.d.js)を指していた typo を、実在する./cjs/index.d.tsに修正する。0.3.1 として publish する。影響
typesが解決できないため、bare import の型がanyにフォールバックしていた。vitest / esbuild ビルドは型チェックしないため実行時の不具合は無く、潜在的な型欠落バグだった。
修正内容
types:./cjs/index.d.js→./cjs/index.d.tsversion: 0.3.0 → 0.3.1検証
pnpm build✅(cjs/index.d.ts生成・Cookie/XHR/LocalStorage/SessionStorage/sendBeaconを export)pnpm lint✅ /pnpm test51 passed ✅types先cjs/index.d.tsの実在を確認 ✅マージ後
master マージで CI が 0.3.1 を ArtifactRegistry へ publish する。bare import を使う im-cmp は 0.3.1 へ更新すると型が正しく付く(任意・別 PR)。subpath import のみの consumer は更新不要。
🤖 Generated with Claude Code