Upgrade rand and dalek#225
Merged
Merged
Conversation
Member
|
Rand removed the reseeding rng. Our options are:
I opted to go with 3 because a simple reseeding rng is very easy and obvious if it's correct or not and it gives us the guarantees we had before. I also followed the standard 64KB of randomness before reseeding. This allows for more than 150 plaintexts in the case of 256 bit and we only need 32 random bytes from the system to reseed. |
Member
|
@giarc3 I'll wait for you to review this as well since a good chunk of it is now my code. |
coltfred
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently-pineed ed25519-dalek broke because of transitive dependencies. Since rand 0.10 is out, we're able to go to the latest pre-release of it instead.
Note: CI will fail because it tries to bench
main, which is broken