Conversation
BobWall23
approved these changes
Apr 29, 2026
coltfred
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to update examples to the latest TSC version I found that all imports failed. This was introduced between 4.0.0 and 4.1.0. When depending on 4.1.0 and later, there would be 2 nested
srcdirectories so thepackage.jsondidn't point to the correct files.The culprit was
import {version} from "../package.json";. When importing from outside thesrcdirectory, it implicitly changed therootDirfor the project and pushed everything down an extrasrc/. This change both fixes the offending line and also manually sets therootDirso it can't happen again.