Skip to content

Conversation

@lposen
Copy link
Contributor

@lposen lposen commented Oct 10, 2025

lposen and others added 30 commits October 6, 2025 19:10
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
…sses' into jwt/MOB-10947-task-3-android-retrypolicy-config-at-android-br
@lposen lposen marked this pull request as ready for review December 10, 2025 23:51
…al-not-respected-always-def

[SDK-196] Fix retryInterval not being able to be updated
Copy link
Member

@Ayyanchira Ayyanchira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a long merge! Such a great revamp! Great one Loren for all the efforts!

}

@ReactMethod
fun generateJwtToken(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit pick: generation logic could be unnecessary as its done on server side. It helps to test the behavior locally quickly. But Devs might get confused if app is where generation should happen.

@lposen lposen merged commit 1c7b504 into master Dec 11, 2025
8 of 11 checks passed
@lposen lposen deleted the jwt/master branch December 11, 2025 04:36
}
}
} catch (Exception e) {
IterableLogger.e(TAG, "Failed to update retry policy: " + e.getMessage());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 22 lines of identical code in 2 locations (mass = 151) [qlty:identical-code]

}
}
} catch (Exception e) {
IterableLogger.e(TAG, "Failed to update retry policy: " + e.getMessage());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 22 lines of identical code in 2 locations (mass = 151) [qlty:identical-code]

*
* @return A JWT string
*/
public static String generateToken(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 2 issues:

1. Function with many parameters (count = 4): generateToken [qlty:function-parameters]


2. Function with high complexity (count = 7): generateToken [qlty:function-complexity]

durationMs: Double,
email: String?,
userId: String?,
promise: Promise
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with many parameters (count = 5): generateJwtToken [qlty:function-parameters]

UIApplication.shared.registerForRemoteNotifications()
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 6): setupUserNotificationCenter [qlty:function-complexity]

) {
return true;
}
return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function with high complexity (count = 5): isIterableAuthResponse [qlty:function-complexity]

if ((promiseResult as IterableAuthResponse).successCallback) {
(promiseResult as IterableAuthResponse).successCallback?.();
if (promiseResult.successCallback) {
promiseResult.successCallback?.();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

// We are currently only reporting JWT related errors. In
// the future, we should handle other types of errors as well.
if (promiseResult.failureCallback) {
promiseResult.failureCallback?.();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deeply nested control flow (level = 4) [qlty:nested-control-flow]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants