Skip to content

Compute Froude and vmax only when needed - #54

Merged
lrntct merged 2 commits into
ItziModel:mainfrom
lrntct:on_demand_vdir_froude
Aug 13, 2026
Merged

Compute Froude and vmax only when needed#54
lrntct merged 2 commits into
ItziModel:mainfrom
lrntct:on_demand_vdir_froude

Conversation

@lrntct

@lrntct lrntct commented Aug 13, 2026

Copy link
Copy Markdown
Contributor
  • Resolves Velocity direction and Froude number should be computed on demand #7
  • benchmark results for solve_h():
    • ~5.5% increase in compute time when those values continue to be computed at each time-step (unlikely to happen in real life)
    • 73% decrease in compute time when none are computed
  • For the whole surface flow, this represents a ~30% decrease in compute time.

@lrntct lrntct changed the title Froude and vmax are computed only when needed Compute Froude and vmax only when needed Aug 13, 2026
@lrntct lrntct added this to the Version 0.5.0 milestone Aug 13, 2026
@lrntct

lrntct commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

The tests went from 6min to 5min 🙂

@lrntct
lrntct merged commit eeca5db into ItziModel:main Aug 13, 2026
9 checks passed
@lrntct
lrntct deleted the on_demand_vdir_froude branch August 13, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Velocity direction and Froude number should be computed on demand

1 participant