Skip to content

add unit tests to cleanup.R#77

Merged
the-mayer merged 13 commits into
JRaviLab:mainfrom
awasyn:test-cleanup
Dec 19, 2025
Merged

add unit tests to cleanup.R#77
the-mayer merged 13 commits into
JRaviLab:mainfrom
awasyn:test-cleanup

Conversation

@awasyn

@awasyn awasyn commented Oct 8, 2024

Copy link
Copy Markdown
Collaborator

Add unit tests to cleanup

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@the-mayer

@jananiravi jananiravi added the outreachy for outreachy interns label Oct 20, 2024
@awasyn
awasyn requested a review from the-mayer October 24, 2024 15:40
@the-mayer

Copy link
Copy Markdown
Collaborator

Similary to #75, bringing this PR up to date with main and making final adjustments so we can get it ready to merge.

@the-mayer the-mayer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests inspired a bit of a refactor for condenseRepeatedDomains() that should now handle additional domain separators more gracefully. Thanks!

@the-mayer
the-mayer requested a review from jananiravi November 12, 2025 16:45
@the-mayer
the-mayer merged commit e0a8b1b into JRaviLab:main Dec 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

outreachy for outreachy interns

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants