feat(mcp): add read-only trust explanation and submission helpers#460
feat(mcp): add read-only trust explanation and submission helpers#460Kelvinchen03 wants to merge 8 commits into
Conversation
📝 WalkthroughWalkthroughThis PR adds three new read-only MCP tools to the registry: ChangesMCP Registry Trust Tools
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
JSONbored
left a comment
There was a problem hiding this comment.
Thanks, but this cannot merge as-is. validate-mcp and endpoint validation both fail because packages/mcp/src/registry.js has invalid JS syntax, and the branch now overlaps with MCP trust helpers already present on main (get_submission_policy, explain_entry_trust, and review_entry_safety). Please rebase against current main, remove duplicate/overlapping tool wiring, align any remaining helper names with the current MCP API, and add passing MCP schema/response tests. Until then this does not fully satisfy #450.
607e490 to
a7ec721
Compare
Thanks for the follow-up here. I’m going to close this PR. The previous change request asked for the branch to be rebased against current main, remove duplicate/overlapping MCP helper wiring, align the remaining helper names/scope with the current MCP API, and add passing MCP schema/response tests. The syntax/check failures are fixed now, but the substantive scope issues are still present:
|
Pull Request
Summary
Closes #450: Added three new read-only MCP helper tools for trust analysis, entry comparison, and submission guidance:
explain_entry_trust - Provides conservative trust analysis for registry entries, explicitly identifying available metadata and missing information
compare_entry_trust - Compares trust indicators and safety metadata across 2-5 entries side-by-side
get_submission_guidance - Provides category-specific submission guidance with field validation
All tools follow read-only patterns, use conservative language (no absolute security claims), and integrate seamlessly with existing MCP infrastructure.
Submission Source
content/<category>/submittedByandsubmittedByUrlfrontmatter matching the PR author.README.md, generated registry outputs, orapps/web/public/downloads/**unless this is a maintainer/internal automation branch./downloads/...package hosting for community-submitted ZIP/MCPB artifacts.Schema and Quality Checks
pnpm validate:contentpassedpnpm validate:packagespassedpnpm scan:packagespassed when package artifacts changedpnpm audit:contentran and I reviewed findingsviewCount,copyCount,popularityScore)skillType,skillLevel,verificationStatus,verifiedAt,retrievalSources,testedPlatforms)Validation
pnpm build)Notes
Files Modified
packages/mcp/src/schemas.js
Added ExplainEntryTrustInputSchema, CompareEntryTrustInputSchema, GetSubmissionGuidanceInputSchema
Registered schemas in TOOL_INPUT_SCHEMAS
packages/mcp/src/registry.js
Implemented explainEntryTrust() function (~82 lines)
Implemented compareEntryTrust() function (~62 lines)
Implemented getSubmissionGuidance() function (~69 lines)
Added tools to READ_ONLY_TOOL_NAMES array
Added tool definitions to TOOL_DEFINITIONS array
Added routing in callRegistryTool() switch statement
packages/mcp/src/registry.d.ts
packages/mcp/src/schemas.d.ts
tests/mcp-server.test.ts