Rework container builds#349
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reworks container image building and publishing to use a file-based mise task with custom Podman setup, while adding Docker Hub as an additional image registry for redundancy.
Changes:
- Replaces the container CD build/push flow with
mise run build:containerand static Podman setup. - Updates the Dockerfile build/runtime stages for multi-architecture standalone binaries.
- Documents Docker Hub usage and adjusts ignore rules/configuration for the new mise task layout.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
README.md |
Documents multiple container registries and updates validation instructions. |
Dockerfile |
Reworks builder/runtime image construction and architecture targeting. |
.oxfmtrc.json |
Updates formatter options. |
.mise/tasks/build/container.sh |
Adds the container build/publish task. |
.mise/snippets/get_ctx.sh |
Adds Git commit context helper. |
.mise/snippets/condition_cmd.sh |
Adds command availability guard helper. |
.mise/snippets/condition_ci.sh |
Adds CI environment guard helper. |
.gitignore |
Allows .mise task files to be tracked. |
.github/workflows/cd.yml |
Replaces action-based container build/push with mise + Podman workflow steps. |
.dockerignore |
Includes .mise files in the Docker build context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enh: move to file based script
enh: custom podman
fix: arm64 images
feat: add docker.io registry
enh: cleanup
Closes #213