Parameterize tests in logic.formatter.bibtexfields #14258
+62
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
requested changes
Nov 11, 2025
Comment on lines
+29
to
+35
| // combining accents | ||
| "{\\\"{a}}, a\u0308", | ||
| "{\\\"{a}}b, a\u0308b", | ||
|
|
||
| // plain unicode letters | ||
| "{\\\"{a}}, ä", | ||
| "{{$\\Epsilon$}}, \u0395" |
Member
There was a problem hiding this comment.
Please use text blocks here. See https://devdocs.jabref.org/code-howtos/testing.html#use-paramterizedtests for an example, Youc an use , as delimiter.
| assertEquals("1~{A}", formatter.format("1 A")); | ||
| assertEquals("1\\mbox{-}{mA}", formatter.format("1-mA")); | ||
| @ParameterizedTest | ||
| @CsvSource({"1~{A}, 1 A", "1\\mbox{-}{mA}, 1-mA"}) |
github-actions
bot
added
the
status: changes-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #676
This PR refactors RemoveHyphenatedNewlinesFormatterTest, TrimWhitespaceFormatterTest, UnicodeConverterTest and UnitsToLatexFormatterTest to use parameterized tests (@CsvSource and @valuesource) following the one-assertion-per-test guideline.
Note: My classmates are also contributing to this issue.
@espertusnu
How to test: