Fix Only failes on parsing from floating point to int not long #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deserializing a floating-point value onto an integer property. 1. implement long throw exception from floating-point to long 2. update global.json 6.0.200 3. add test case for JamesNK#2664
|
Hi @isdaniel, we'd love to see this merged at some point. Is there anything we can do to help? |
…floating-point-not-long-#2664 # Conflicts: # Src/Newtonsoft.Json.Tests/JsonTextReaderTests/ExceptionHandlingAsyncTests.cs # Src/Newtonsoft.Json.Tests/JsonTextReaderTests/ReadAsyncTests.cs # Src/Newtonsoft.Json.Tests/Serialization/JsonSerializerTest.cs # Src/global.json
Author
|
I am glad you like this MR. I saw there were some conflicts created by the new modification. Now, I have fixed it. |
Author
|
Hi @JamesNK Could you please take look at this? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR will let
int&longhave the same behaviour for throwing an error when deserializing a floating-point value onto an integer property.As before discussed in #654 Error converting float value to integer in Web API
But now that only worked in
intbut not inlongI had added some unit tests to make sure
longbehaviour will be as same asintI also saw there is another issue #2664, this MR might solve this problem.