ci(labeler): label changes to the documentation site as docs - #3
Merged
Conversation
The docs rule listed the four markdown files at the repository root and nothing else, so it predates the documentation site: a pull request touching only docs/ came out unlabelled, as did one touching the images or the scripts that generate them. The seven labels the config refers to now exist in the repository — they never did, so actions/labeler had nothing to apply.
github-actions
Bot
added
the
ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while creating the labels the labeler needs.
Two things were wrong:
The labels did not exist.
actions/labelerapplies labels, it does not create them, so every rule in.github/labeler.ymlwas a no-op. All seven now exist (core,commands,shell,output,tests,docs,ci), with descriptions and a consistent palette — that part needed no code change.The
docsrule predates the documentation site. It matched the four markdown files at the repository root and nothing else, so a PR touching onlydocs/came out unlabelled — as did one touchingassets/or thescripts/that generate them. This adds those globs plus.readthedocs.yaml.