[DBA-141] Add field validations on datasource adding by SimonKaran13 · Pull Request #81 · JetBrains/databao-cli

SimonKaran13 · 2026-03-26T12:43:49Z

Summary

Datasource names with spaces and special characters were accepted in the form but caused errors after submission. This adds frontend validation so users get clear, immediate feedback.

Changes

Shared validation module

New validate_datasource_name() function enforcing name rules:

Folder segments (before the last /): alphanumeric, hyphens, underscores, dots
Source name (last segment): must start with a letter and contain only letters, digits, and underscores (matches the agent's SQL-safe constraint)

Also includes validate_port() (1–65535 range) and validate_hostname() (RFC 952/1123 + IPv4/IPv6 via stdlib ipaddress).

Files

src/databao_cli/features/datasource/validation.py

UI validation

Validate name before add/verify actions; check required config fields, port ranges, hostname format, and union property variants. The "Verify connection" button now also runs config field validation before attempting verification.

Files

src/databao_cli/features/ui/components/datasource_manager.py
src/databao_cli/features/ui/components/datasource_form.py

CLI validation

Validation loop in the interactive CLI workflow.

Files

src/databao_cli/workflows/datasource/add.py

Tests

Unit tests covering the validation module and validate_config_fields() (int vs port split, union properties, top-level key scoping, hostname-with-port rejection).

Files

tests/test_datasource_validation.py
tests/test_datasource_form_validation.py

Test Plan

make check passes
make test passes (140 tests)
UI tested with Playwright: spaces, special chars, empty name show correct errors

Add frontend validation for datasource names in both the Streamlit UI and CLI workflow. Names with spaces, special characters, and other invalid patterns are rejected with clear error messages before submission instead of failing on the backend. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Use the agent's source name pattern (^[A-Za-z][A-Za-z0-9_]*$) for the last segment so names work unquoted in SQL. Add validate_port() and validate_hostname() validators, applied automatically to config fields based on their key name and type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Adds shared datasource field validation to prevent invalid datasource names/config values from being accepted in the Streamlit UI and interactive CLI, improving feedback before submission and aligning test fixtures with the stricter naming rules.

Changes:

Introduces a shared validation module for datasource names plus host/port validation helpers.
Adds pre-submit validation in Streamlit datasource management and in the interactive CLI add workflow.
Adds unit tests for the shared validation module and updates e2e test fixtures to use underscore-based datasource names/ids.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`src/databao_cli/features/datasource/validation.py`	New shared validation helpers for datasource name, hostname, and port.
`src/databao_cli/workflows/datasource/add.py`	Loops until a valid datasource name is entered in the CLI workflow.
`src/databao_cli/features/ui/components/datasource_manager.py`	Validates datasource name/type before add/verify; validates required config fields before add.
`src/databao_cli/features/ui/components/datasource_form.py`	Adds config-field validation (required fields + host/port checks).
`tests/test_datasource_validation.py`	New unit tests for the shared validation module.
`e2e-tests/tests/resources/sqlite_introspections.yaml`	Updates datasource id/comment to match underscore naming.
`e2e-tests/tests/resources/duckdb_introspections.yaml`	Updates datasource id/comment to match underscore naming.
`e2e-tests/src/databases/sqlite_utils.py`	Updates default sqlite datasource name to underscore form.
`e2e-tests/src/databases/duckdb_utils.py`	Updates default duckdb datasource name to underscore form.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/databao_cli/features/datasource/validation.py

src/databao_cli/features/ui/components/datasource_form.py

src/databao_cli/features/ui/components/datasource_manager.py

gasparian

The "Save" path for existing datasources (datasource_manager.py:196-208) doesn't run any validation before persisting. A user could edit a datasource, clear a required field or type garbage into the port/host inputs, hit Save, and the invalid config gets written to disk without complaint. Seems like validate_config_fields() should be called here too, same as the "Add datasource" flow does.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

src/databao_cli/features/datasource/validation.py

src/databao_cli/features/ui/components/datasource_form.py

src/databao_cli/features/datasource/validation.py

…fy path - Use stdlib ipaddress for IP validation instead of colon heuristic - Catch all whitespace (tabs, newlines, NBSP) not just spaces - Split int parsing from port range validation (only port-named fields) - Validate union property variants recursively - Apply SKIP_TOP_LEVEL_KEYS only at top level, not nested - Run config field validation on "Verify connection" path - Update PR description to match actual name constraints - Add tests for all changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

SimonKaran13 · 2026-03-30T08:55:27Z

@gasparian Addressed in 35eb85f — the "Save" path for existing datasources now runs validate_config_fields() before persisting, same as the "Add datasource" and "Verify connection" paths.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

src/databao_cli/features/ui/components/datasource_form.py

src/databao_cli/features/datasource/validation.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

src/databao_cli/features/datasource/validation.py

tests/test_datasource_validation.py

…ant union fallback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

src/databao_cli/features/ui/components/datasource_form.py

src/databao_cli/features/datasource/validation.py

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

src/databao_cli/features/datasource/validation.py

SimonKaran13 and others added 2 commits March 26, 2026 13:43

[DBA-141] Extract shared validation helper in datasource manager

d6e65f1

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

SimonKaran13 self-assigned this Mar 26, 2026

SimonKaran13 and others added 2 commits March 26, 2026 14:03

[DBA-141] Remove screenshot from repo

f3ca6da

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

gasparian self-requested a review March 26, 2026 17:10

fixes to pass e2e

cf3edf0

gasparian marked this pull request as ready for review March 27, 2026 10:16

gasparian requested a review from a team March 27, 2026 10:16

SimonKaran13 requested a review from Copilot March 27, 2026 10:17

Copilot started reviewing on behalf of SimonKaran13 March 27, 2026 10:17 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

gasparian requested changes Mar 27, 2026

View reviewed changes

igRo requested a review from Copilot March 27, 2026 17:05

Copilot started reviewing on behalf of igRo March 27, 2026 17:06 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

SimonKaran13 and others added 2 commits March 30, 2026 10:38

[DBA-141] Validate config fields on existing datasource save

35eb85f

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 30, 2026 08:53

Copilot started reviewing on behalf of SimonKaran13 March 30, 2026 08:54 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

src/databao_cli/features/ui/components/datasource_form.py Show resolved Hide resolved

src/databao_cli/features/datasource/validation.py Outdated Show resolved Hide resolved

[DBA-141] use 'whitespace' in the error message instead of 'space'

bae1a63

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 30, 2026 09:39

Copilot started reviewing on behalf of SimonKaran13 March 30, 2026 09:39 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

src/databao_cli/features/datasource/validation.py Outdated Show resolved Hide resolved

tests/test_datasource_validation.py Outdated Show resolved Hide resolved

tests/test_datasource_validation.py Outdated Show resolved Hide resolved

SimonKaran13 and others added 2 commits March 30, 2026 14:11

[DBA-141] Remove bracket handling from IP validation, add single-vari…

bdaf9e5

…ant union fallback Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

[DBA-141] Fix test assertions to match updated whitespace error message

79a0c5f

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 30, 2026 12:12

Copilot started reviewing on behalf of SimonKaran13 March 30, 2026 12:13 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

src/databao_cli/features/ui/components/datasource_form.py Show resolved Hide resolved

src/databao_cli/features/datasource/validation.py Outdated Show resolved Hide resolved

[DBA-141] Add multi-variant union error, clarify empty-segment message

d9dae92

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

SimonKaran13 requested a review from Copilot March 30, 2026 12:27

Copilot started reviewing on behalf of SimonKaran13 March 30, 2026 12:28 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

src/databao_cli/features/datasource/validation.py Show resolved Hide resolved

SimonKaran13 requested a review from gasparian March 30, 2026 13:13

gasparian approved these changes Mar 30, 2026

View reviewed changes

gasparian merged commit cecae36 into main Mar 30, 2026
10 checks passed

gasparian deleted the simon.karan/DBA-141-field-validations-on-datasource-adding branch March 30, 2026 16:56

Conversation

SimonKaran13 commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Shared validation module

UI validation

CLI validation

Tests

Test Plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gasparian left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SimonKaran13 commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SimonKaran13 commented Mar 26, 2026 •

edited

Loading

SimonKaran13 commented Mar 30, 2026 •

edited

Loading