Repository navigation
👷 QD-16987 Build arm64 base images on native runners instead of QEMU (262) - #1142
Closed
Ivan Efimov (ivanovec) wants to merge 1 commit into
Closed
Ivan Efimov (ivanovec) wants to merge 1 commit into
Ivan Efimov (ivanovec) wants to merge 1 commit into
Conversation
…1137) * 👷 QD-16987 Build arm64 base images on native runners instead of QEMU QEMU-emulated arm64 builds on ubuntu-latest are slow and intermittently crash Node/V8 with SIGILL (exit code 132). - Build each bake group per platform: amd64 on ubuntu-latest, arm64 on ubuntu-24.04-arm; drop setup-qemu - On push, push untagged images by digest (a tagged ref can't be pushed by digest), then the merge job creates the multi-arch tags from docker-bake.hcl via `docker buildx imagetools create` - Use a separate GHA cache scope per group and platform instead of one shared "provenance" scope overwritten by all jobs * 👷 QD-16987 Address review: push mode in docker-bake.hcl, merge script in Python - docker-bake.hcl: BASE_PLATFORMS / PUSH_BY_DIGEST variables and a tags() function replace the jq bake override (based on the patch from review) - matrix platform as objects instead of include - group list shared via YAML anchor, comments restored, groups job removed - merge logic moved to .github/scripts/merge-base-images.py; validates the whole group before tagging, so tags are never partially updated (cherry picked from commit f603f9a)
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Qodana for Go129 new problems were found
@@ Code coverage @@
+ 69% total lines covered
11120 lines analyzed, 7706 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
Backport of #1137 to
262(clean cherry-pick of f603f9a with-x).Base images are built natively per platform instead of under QEMU: amd64 on
ubuntu-latest, arm64 onubuntu-24.04-arm. On push, every target is pushed by digest; themergejob then creates the multi-arch tags fromdocker-bake.hclvia.github/scripts/merge-base-images.py.Related Issue
QD-16987
Motivation and Context
Node/V8 under QEMU crashes randomly on arm64 (
qemu: uncaught target signal 4, exit 132), which makes the Base workflow flaky on release branches too.How Has This Been Tested
.github/workflows/base.yml,docker-bake.hcland.github/scripts/on262were identical tomainbefore 👷 QD-16987 Build arm64 base images on native runners instead of QEMU #1137, so the change is the same as inmain.actionlint1.7.12: clean.docker buildx bake --printfor all 13 groups, default andPUSH_BY_DIGEST=true BASE_PLATFORMS=linux/arm64: OK.mergejob run after merge.Types of changes