-
Notifications
You must be signed in to change notification settings - Fork 4
Implement caching of SVO filters #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 80.60% 80.10% -0.51%
==========================================
Files 6 6
Lines 366 397 +31
==========================================
+ Hits 295 318 +23
- Misses 71 79 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/svo.jl
Outdated
| errval = simple_value(children(info)[1]) | ||
| if errval == "Filter not found:" | ||
| errval *= " $id" | ||
| filename = joinpath(filter_cache, replace(filtername, "/" => "_") * "_" * string(magsys) * ".txt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would save these as .xml files instead
|
It works really well and looks good to me! I have added one comment in the review (xml vs. txt files) and also added a PR adding One thing one could still add is a keyword argument to |
|
Couple updates:
With these features complete I think we should be good to merge this and register the package. What do you think @lucasvalenzuela ? |
|
Everything works beautifully! For the docstrings I noticed you put in two method documentations in the same triple quotation marks block - does that actually work? I am used to seeing separate docstrings for each method. Apart from that I think this is ready to go and be registered. |
|
It does work but it's kind of a bad habit, I think it's better form to have multiple docstrings so I changed that now. Thanks for all your help! I'll merge this and try and register the package when I get a chance. You think we should register at 1.0? |
|
I saw you already bumped it to 1.0 - in any case I don't have any preference on 1.0 or 0.1. Fantastic to see this getting this registered soon, thanks for all your work on this package! |
Implements caching of filters queried from SVO. Includes an
update_filters()function that will redownload all cached filters from SVO, effectively refreshing the cache.@lucasvalenzuela how does this look?