-
Notifications
You must be signed in to change notification settings - Fork 10
Add pledgeinsize
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pledgeinsize
#64
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 61.49% 63.11% +1.61%
==========================================
Files 4 4
Lines 361 366 +5
==========================================
+ Hits 222 231 +9
+ Misses 139 135 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| write(s, b"Hello") | ||
| close(s) | ||
| buffer3 = take!(sink) | ||
| @test CodecZstd.find_decompressed_size(buffer3) == CodecZstd.ZSTD_CONTENTSIZE_UNKNOWN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transcode with ZstdCompressor now records the decompressed size.
mkitti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Julia functions should not return error codes. They should throw exceptions.
|
What is the status of this pull request at the moment? |
|
It has some minor conflicts that need to be resolved. I also want to try to maintain support for older versions of TranscodingStreams. |
This is part of JuliaIO/TranscodingStreams.jl#239
This PR reduces the allocations needed when decompressing data compressed with
transcode.For example:
With this PR and JuliaIO/TranscodingStreams.jl#239:
416.579 ns (4 allocations: 10.05 KiB)
Before:
510.451 ns (5 allocations: 19.72 KiB)