Skip to content

Conversation

@felixcremer
Copy link
Contributor

This makes size(zarr, dimnum= return 1 for to large dimensions numbers and give a better error message for negative dimension numbers.

This is needed so that concatenation of cubes backed by a Zarr array still work in DiskArrays after
JuliaIO/DiskArrays.jl#280

@coveralls
Copy link

Pull Request Test Coverage Report for Build 18913411990

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 89.338%

Totals Coverage Status
Change from base Build 18793430184: 0.05%
Covered Lines: 972
Relevant Lines: 1088

💛 - Coveralls

@felixcremer
Copy link
Contributor Author

The nightly failures are an unrelated Pkg loading of precompiled packages problem and the codecov check is just strange. Because on codecov itself it looks as if all lines are hit.

Copy link
Member

@nhz2 nhz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though a more basic error message without string interpolation might slightly improve performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants