Skip to content

Conversation

@nhz2
Copy link
Member

@nhz2 nhz2 commented Jun 28, 2025

Base.FastContiguousSubArray is private, and Base.cconvert + Base.unsafe_convert is safer under potential future GC changes compared to the pointer function.

@codecov
Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (d49d569) to head (cd6d538).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #94   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files           6        6           
  Lines         821      821           
=======================================
  Hits          816      816           
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nhz2 nhz2 merged commit 8647ce9 into main Jun 28, 2025
21 checks passed
@nhz2 nhz2 deleted the cleanup-pointer-usage branch June 28, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants