Display backtrace from unexpected errors in terminate_all_workers()#187
Merged
JamesWrigley merged 1 commit intomasterfrom Apr 14, 2026
Merged
Display backtrace from unexpected errors in terminate_all_workers()#187JamesWrigley merged 1 commit intomasterfrom
terminate_all_workers()#187JamesWrigley merged 1 commit intomasterfrom
Conversation
JamesWrigley
force-pushed
the
rmprocs-timeout
branch
from
e89bd9e to
14fa32c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 79.47% 79.39% -0.09%
==========================================
Files 10 10
Lines 1959 1961 +2
==========================================
Hits 1557 1557
- Misses 402 404 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vchuravy
approved these changes
Apr 14, 2026
vchuravy
reviewed
Apr 14, 2026
| catch _ex | ||
| @warn "Forcibly interrupting busy workers" exception=_ex | ||
| if _ex isa ErrorException | ||
| @warn "Forcibly interrupting busy workers" exception=_ex |
Member
There was a problem hiding this comment.
Should we show the backtrace in all cases?
Member
Author
There was a problem hiding this comment.
I thought about that, but I'd lean against it because rmprocs() timing out is semi-expected and I don't think we want to display a full stacktrace for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping this will help debug failures like these: https://buildkite.com/julialang/julia-master/builds/56445/steps/canvas?sid=019d7e70-1b2a-4462-8d03-2a44509e7792#019d7e70-1b59-4033-960c-cf31781e32f6/L2025