Skip to content

Prevent overflow in mean(::AbstractRange) and relax type constraint.#150

Merged
ararslan merged 3 commits intoJuliaStats:masterfrom
chunjiw:master
Sep 14, 2023
Merged

Prevent overflow in mean(::AbstractRange) and relax type constraint.#150
ararslan merged 3 commits intoJuliaStats:masterfrom
chunjiw:master

Conversation

@chunjiw
Copy link
Copy Markdown
Contributor

@chunjiw chunjiw commented Sep 1, 2023

This is almost an exact copy of #115. This should fix JuliaLang/julia#50982 as well.

My understanding is that #115 is still open because too many commits are ahead of it. So someone needs to make a similar pull request. So here it is.... I have contributed to open source before but not experienced, so please let me know if I missed anything.

and relax type constraint
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/Statistics.jl 100.00%

📢 Thoughts on this report? Let us know!.

@mschauer
Copy link
Copy Markdown
Member

mschauer commented Sep 1, 2023

Looks good!

Copy link
Copy Markdown
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Comment thread src/Statistics.jl Outdated
@nalimilan nalimilan requested a review from ararslan September 9, 2023 15:52
chunjiw and others added 2 commits September 9, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mean(::UnitRange) overflows

5 participants