LinearBasisFunctionModels#305
Open
FriesischScott wants to merge 14 commits intomasterfrom
Open
Conversation
Remove ResponseSurface
In the new system it translates to an AdditiveBasis constructed from a PolyharmonicRadialBasis and a MonomialBasis of degree 1.
The PHS has extra constraints and can't be represented by the BasisFunctionModel
FriesischScott
force-pushed
the
basis-function-models
branch
from
09d9024 to
c1af117
Compare
FriesischScott
force-pushed
the
basis-function-models
branch
from
c1af117 to
40a4f9d
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
LinearBasisFunctionModelas a generalization of theResponseSurfaceand similar models.While the
PolyharmonicSplineis technically a radial basis with an added polynomial term it requires a separate type because of added constraints. For consistency I have created an aliasResponseSurfacefor the linear basis function model with a monomial basis.Overall this will make it easier to introduce similar models such as radial basis function networks and especially interval predictor models (#271).
As of now, this includes no new functionality and the existing models should function exactly as before.