TD-8387: remove non-functional deferredResponse; document response shape and pagination#21
Merged
Conversation
…hape and pagination The execute-j1ql-query tool exposed a deferredResponse parameter that was silently dropped before reaching GraphQL — verified empirically by running identical queries with and without the parameter and getting byte-identical responses (same correlationId). The underlying queryV2 operation does not accept deferredResponse at all; it is a queryV1-only argument. Removed: - deferredResponse from the Zod schema and handler in mcp-server.ts - deferredResponse from the parameter table in README.md Added to execute-j1ql-query.md: - Response Shape section enumerating the real envelope (data, type, cursor, totalCount, estimate, status, duration, correlationId, messages, url) - Pagination section stating the cursor rule: continue while cursor is present, regardless of data.length — a zero-row page with non-null cursor is intentional behavior, not a completion signal - Note that totalCount with estimate: true may shift between pages Refs TD-8387. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jzolo22
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two changes addressing TD-8387:
deferredResponseparameter fromexecute-j1ql-query. It was accepted by the Zod schema but silently dropped inj1ql-service.tsbefore reaching GraphQL. The underlyingqueryV2operation does not acceptdeferredResponse(onlyqueryV1does), so even forwarding it would not have worked.execute-j1ql-query.md. The real response envelope (data,type,cursor,totalCount,estimate,status,duration,correlationId,messages,url) was not documented anywhere; theestimateflag in particular was already being returned but was undocumented. Pagination guidance now states the cursor rule explicitly: continue whilecursoris present, regardless ofdata.length.Patch version bump:
0.2.0 → 0.2.1.Empirical verification
Three calls to
execute-j1ql-queryagainst j1dev — no parameter,deferredResponse: 'FORCE',deferredResponse: 'DISABLED'— returned byte-identical responses including the samecorrelationId. With a correctly-wiredFORCE, the response type should flip todeferredwith a download URL; instead all three returnedtype: 'list'with inline data. The parameter has been non-functional since it was introduced.The
estimatefield was confirmed to surface in responses today (estimate: trueobserved on unbounded queries,falseonce the final page resolves).Test plan
deferredResponse)npm run buildsucceedsdeferredResponseFollow-up
After this merges and publishes, a one-line PR will be needed in
jupiterone-remote-mcpto refresh the lockfile and bump1.0.22 → 1.0.23.🤖 Generated with Claude Code