Skip to content

Conversation

@mattcohen24
Copy link

Summary

bug fix for safari, version rev for compatibility, react prop name error

Key Changes

  • rollup version increase, dataTransfer.items doesn't populate on drag events in safari, must use dataTransfer.types to verify user is dragging file, update overRide prop name to override to prevent react from throwing an unknown prop error.

Check List

  • [ not necessary] The changes to the "Readme" file(if needed)
  • [ none] The changes not breaking any old rule of the library or usage

@andrei-padolski
Copy link

andrei-padolski commented Nov 7, 2024

Hi there! Can this one be validated a bit faster? We're having such warnings on our app. Thanks in advance
Screenshot 2024-11-07 at 12 51 41 PM

@Fu-Jose
Copy link

Fu-Jose commented Dec 17, 2024

come on... :(

@rjuevesano
Copy link

any updates?

@KarimMokhtar
Copy link
Owner

solved in #153

@mattcohen24
Copy link
Author

hey @KarimMokhtar the main issue I was hoping to fix with this was the safari drag and drop issue, is it still possible to get that fix merged in?

@KarimMokhtar KarimMokhtar reopened this Mar 28, 2025
@KarimMokhtar
Copy link
Owner

@mattcohen24 yes sure, could you solve the conflicts and remove the change for the version inside the package json?

@mattcohen24
Copy link
Author

@KarimMokhtar sorry for the delay.

@mattcohen24 mattcohen24 changed the title Fix: file drag detection on safari, package compatibility, overRide prop name error Fix: file drag detection on safari Jul 25, 2025
@KarimMokhtar
Copy link
Owner

@mattcohen24 the pipeline is failing. Could you please check.

@mattcohen24 mattcohen24 changed the title Fix: file drag detection on safari fix: file drag detection on safari Aug 1, 2025
@mattcohen24
Copy link
Author

@KarimMokhtar can you rerun the pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants