Skip to content

ci: don't fail build on codecov upload errors#610

Merged
jgamblin merged 1 commit intomainfrom
fix/codecov-fail-ci
Apr 9, 2026
Merged

ci: don't fail build on codecov upload errors#610
jgamblin merged 1 commit intomainfrom
fix/codecov-fail-ci

Conversation

@jgamblin
Copy link
Copy Markdown
Collaborator

@jgamblin jgamblin commented Apr 9, 2026

Summary

  • Change fail_ci_if_error from true to false in the Codecov upload step
  • Codecov upload failures (e.g. "Token required because branch is protected" on Dependabot PRs) were blocking CI even though the actual tests pass
  • Unblocks Bump addressable from 2.8.9 to 2.9.0 #608

Test plan

🤖 Generated with Claude Code

Codecov upload failures (e.g. token issues on Dependabot PRs) should
not block CI. Unblocks #608.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jgamblin jgamblin merged commit d4601d8 into main Apr 9, 2026
11 checks passed
@jgamblin jgamblin deleted the fix/codecov-fail-ci branch April 9, 2026 17:52
jgamblin added a commit that referenced this pull request Apr 9, 2026
…able-2.9.0

Merging as part of Ruby 3.4 upgrade and dependency security cleanup (see #607, #610). Admin merge used to bypass branch protection since CI is fully green.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant