feat: Add shallow water in editor - #1787
Open
dvincent56 wants to merge 2 commits into
Open
Conversation
dvincent56
commented
May 17, 2026
Collaborator
- Use unused shallow assets
- Add shallow tile in editor under water menu
crudelios
reviewed
May 21, 2026
crudelios
left a comment
Collaborator
There was a problem hiding this comment.
I'm not sure you need to increase the savegame version as well.
Collaborator
|
I'm very sure you have to increase the save version as well because terrain grid is saved in both scenario and save game. And otherwise the game will try to load a terrain type which isn't yet in the game. Although this might not be that important since it's a bitflag enum so the game might just ignore the additional terrain bit I think it's good practise at least. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.