Skip to content

feat: Add shallow water in editor - #1787

Open
dvincent56 wants to merge 2 commits into
Keriew:masterfrom
dvincent56:feature/shallows
Open

feat: Add shallow water in editor#1787
dvincent56 wants to merge 2 commits into
Keriew:masterfrom
dvincent56:feature/shallows

Conversation

@dvincent56

Copy link
Copy Markdown
Collaborator
  • Use unused shallow assets
  • Add shallow tile in editor under water menu

@crudelios crudelios left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure you need to increase the savegame version as well.

@Johannes-callidus

Copy link
Copy Markdown
Collaborator

I'm very sure you have to increase the save version as well because terrain grid is saved in both scenario and save game. And otherwise the game will try to load a terrain type which isn't yet in the game. Although this might not be that important since it's a bitflag enum so the game might just ignore the additional terrain bit I think it's good practise at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants