Fix auto clear trees not working for docks, wharves and shipyards#1837
Merged
Johannes-callidus merged 1 commit intoJul 17, 2026
Conversation
Waterside buildings validate placement through map_water_determine_orientation, whose is_blocked_tile helper counted trees and shrubs as blocking regardless of the auto clear trees option. With the option enabled, vegetation on land tiles no longer blocks - the existing placement code then clears and charges for it, and the ghost and cost preview already handle it through the same check.
Collaborator
|
Good job! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waterside buildings validate placement through map_water_determine_orientation, whose is_blocked_tile helper counted trees and shrubs as blocking regardless of the auto clear trees option. With the option enabled, vegetation on land tiles no longer blocks - the existing placement code then clears and charges for it, and the ghost and cost preview already handle it through the same check.