ssd1306: add driver with optimizations - #48
Closed
joy4eg wants to merge 1 commit into
Closed
Conversation
DevyatovAndrey
requested changes
Jan 10, 2018
DevyatovAndrey
left a comment
DevyatovAndrey
left a comment
There was a problem hiding this comment.
Good work in general!
But still it could you please make changes listed below?
| ssd1306_display_update_direct(ctx); | ||
| } | ||
|
|
||
| static void ssd1306_display_update(struct ssd1306_ctx *ctx) |
There was a problem hiding this comment.
There are several display_update methods - that's really confusing. Could you rename these?
|
|
||
| dst = (void __force *) (info->screen_base + p); | ||
|
|
||
| if (copy_from_user(dst, buf, count)) |
There was a problem hiding this comment.
I think there could be used a fb_sys_write method
Signed-off-by: Yaroslav Syrytsia <me@ys.lc>
Author
|
Fixed. |
AleksandrBulyshchenko
requested changes
Jan 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: