Open
Conversation
Kuncheria-KV
commented
Nov 20, 2023
Kuncheria-KV
commented
- Change a prop name to make the component more generic
- Fix type definitions, that were not exported in the final build
…er states, refactored waterfallchart component, util and hook files, fixed an issue where component was getting stuck when value 0 is passed for yAxisPixelsPerUnit
…ed package json with new license and links
arjunrtk-kv
force-pushed
the
refactor/improve-standards
branch
from
1b3dc4e to
4587bd0
Compare
bilta-keyvalue
requested changes
Nov 30, 2023
package.json
Outdated
| { | ||
| "name": "@keyvaluesystems/react-waterfall-chart", | ||
| "version": "0.1.5", | ||
| "version": "1.0.0", |
There was a problem hiding this comment.
No need to change the version manually. There is an option to do it during deployment.Please revert these changes
|
|
||
|
|
||
| The transactions prop is an array of transactions with the following keys: | ||
| The dataPoints prop is an array of dataPoint with the following keys: |
There was a problem hiding this comment.
Since this prop renaming is a breaking change, it would be better to specify it in the readme along with the migration steps. For more info refer other repos that has similar changes
ReshmaJoshy
reviewed
Jan 17, 2024
| } | ||
|
|
||
| export function checkIfScaleSufficient(scale: number, maxLabelsCount: number, valueRange: number): boolean { | ||
| if (maxLabelsCount === 0) return true; // to stop the while loop from checking for sufficient scale with zero maxLabelsCount |
There was a problem hiding this comment.
Removed the line since it is unreachable code; the case where maxLabelsCount = 0 is already addressed earlier in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.