MSL: Fix boolean spec const as_type<> invalid output #2536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `emit_specialization_constants_and_structs` to deduplicate function constants and handle boolean types correctly, avoiding illegal bitcasting in Metal. - Modified `bitcast_glsl_op` to prevent bitcasting to/from boolean types, ensuring compliance with Metal's restrictions. - Added a new test shader `spec-constant-bool-mixed.asm.frag` to validate the behavior of mixed specialization constants with the same SpecId for boolean and uint types.
|
|
HansKristian-Work
approved these changes
Aug 29, 2025
Contributor
HansKristian-Work
left a comment
HansKristian-Work
left a comment
There was a problem hiding this comment.
Surprised this is even legal, but LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RenderDoc generates SPIR-V that may reuse boolean specialization constants, resulting in invalid MSL being generated.
emit_specialization_constants_and_structsto deduplicate function constants and handle boolean types correctly, avoiding illegal bitcasting in Metal.bitcast_glsl_opto prevent bitcasting to/from boolean types, ensuring compliance with Metal's restrictions.spec-constant-bool-mixed.asm.fragto validate the behavior of mixed specialization constants with the same SpecId for boolean and uint types.