-
Notifications
You must be signed in to change notification settings - Fork 14
feat(gastown): add debug replay-events endpoint for reconciler phase 5 #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jrf0110
wants to merge
4
commits into
main
Choose a base branch
from
convoy/reconciler-phase-5-debug-endpoints-grafa/4763028e/head
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
49754d6
fix: skip container_status events for running containers (#1368)
jrf0110 f63be07
feat(gastown): add POST /debug/reconcile-dry-run endpoint (#1367)
jrf0110 c8a756f
feat(gastown): add debug dry-run endpoint with event draining (#1370)
jrf0110 9a634bf
feat(gastown): add POST /debug/replay-events endpoint for event repla…
jrf0110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING: Replaying onto live state double-applies historical events
debugReplayEvents()starts from the current town tables, then runs each selected event through non-idempotent handlers likereviewQueue.agentDone()andcompleteReviewWithResult(). If the selected window has already been processed, this can target different beads than it originally did and return actions/snapshots that never would have existed atfrom. A real replay needs to start from a state snapshot taken before the requested range (or otherwise reset the affected state before applying the events).