Skip to content

Conversation

@n7studios
Copy link
Contributor

Summary

In the Setup Wizard, sets the browser tab title to 'Kit', instead of 'ConvertKit'

Before:
Screenshot 2025-12-16 at 15 33 35

After:
Screenshot 2025-12-16 at 15 34 55

Testing

Existing tests pass.

Checklist

@n7studios n7studios self-assigned this Dec 16, 2025
<head>
<meta name="viewport" content="width=device-width"/>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
<title><?php echo esc_html( CONVERTKIT_PLUGIN_NAME ); ?> &lsaquo; <?php bloginfo( 'name' ); ?> &#8212; WordPress</title>
Copy link
Contributor Author

@n7studios n7studios Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This used to use the constant CONVERTKIT_PLUGIN_NAME, defined here.

The only other place this constant is used is as part of the user agent string in API requests; I'm unsure if API logs rely on it stating 'ConvertKit'. Happy to change the constant value if it won't break anything on the API/log side.

@n7studios n7studios changed the base branch from main to tests-fix-wp-optimize December 17, 2025 12:09
@github-actions
Copy link

WordPress Playground

🚀 Your PR has been built and is ready for testing in WordPress Playground!

Click here to test your changes in WordPress Playground

@n7studios n7studios requested review from a team, ciccio-kit and noelherrick and removed request for a team December 17, 2025 12:46
@n7studios n7studios marked this pull request as ready for review December 17, 2025 12:46
Copy link
Contributor

@noelherrick noelherrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preliminary answer is no, changing the plugin name shouldn't affect anything on the Kit app/logging side, but I will do some research.

@n7studios n7studios merged commit a775510 into tests-fix-wp-optimize Dec 18, 2025
151 of 154 checks passed
@n7studios n7studios deleted the setup-wizard-fix-name branch December 22, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants