-
Notifications
You must be signed in to change notification settings - Fork 23
Add the option to have the type list on the bottom of the screen #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattdawkins
wants to merge
28
commits into
main
Choose a base branch
from
bottom-type-list
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Reset localNotesDisplay when track ID changes to prevent stale notes from a previously edited track showing on other tracks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
73f8fab to
49b5198
Compare
The TypeScript client viame parser already supported parsing (note) entries from VIAME CSV files, but the Python server parser did not. This caused a test failure because both parsers share the same test data file (viame.spec.json). Changes: - Add notes field to Feature model - Parse (note) entries in viame.py _parse_row function - Update test data to include expected notes output Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The Advanced Tools panel was previously disabled in bottom mode due to layout conflicts. This change enables it by using fixed positioning when in bottom mode, so it overlays the annotation area without affecting the layout. Changes: - Remove context.resetActive() when switching to bottom mode - Show Advanced Tools button in all sidebar modes - Pass sidebarMode to SidebarContext via scoped slot - Use fixed positioning in bottom mode (top: 112px, above 260px bottom bar) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Ensure the tooltip appears above the expanded panel by setting z-index to 20 (panel has z-index 10). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add TrackListColumnSettings component for configuring visible columns - Support toggling: Start Frame, End Frame, Start/End Timestamps, Notes - Support adding arbitrary track or detection attributes as columns - Settings persist via localStorage - Timestamps require FPS metadata to be enabled Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add event handlers and state management for attribute editing in the bottom panel details view. This includes adding the AttributeEditor dialog, edit-individual state for inline editing, and all necessary event handlers (edit-attribute, set-edit-individual, add-attribute). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Move attribute columns before notes in column settings UI and track list - Add sortable timestamp columns (Start Time, End Time) - Add sortable attribute columns (track and detection level) - Timestamps sort by underlying frame number for accuracy Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Make start/end timestamp columns clickable to seek to that frame - Remove redundant seek to start/end buttons (clicking frames already does this) - Add editable attribute values directly in the track list columns - Show orphaned attribute columns in settings so they can be disabled Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Allow users to show/hide the Type and Confidence columns in the bottom track list view through the column settings panel. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a flexible sidebar layout system and adds editable notes functionality to the track list, improving
the annotation workflow especially for multi-camera datasets.
New Layout Options
screen space for multi-camera datasets
Bottom Panel Layout
(attributes, confidence scores)
Editable Notes in Track List
Multi-Camera Toolbar Improvements
Test Plan