Added access to elements that observable is bound to and some events V1.0 #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding an array of elements on each observable so we can tell what elements if any that this observable is bound on. This is useful so we can hook into a validation error later and use an external lib like qtip to display the error messages instead of just inserting a span into the html.
…idation Conflicts: Src/knockout.validation.js
…ation Conflicts: Src/knockout.validation.js
… calling the onValidationStart event correctly
Member
|
Ok - I'm really sorry for the delay on getting to this - we've had some projects at work that I haven't been able to peel away from. A couple thoughts-
Is your main purpose here to meet your needs with QTip? If so, I'll try to take stab at a suggested strategy for that. |
…he observable but instead using the validationElement binding to fire off an event that I can hook into with qTip and display the messages.
Member
|
Thanks for that - the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to say in my first request, great work! I love this extension for knockout!
Here is one based on v1.0. I closed the other pull request.
I made this change to be able to access the element(s) that the observable is bound to so I can use qtip to display the messages on validation error instead of inserting it right next to it.
The events are needed so I can fire off a function when it is all done, onValidationStart and onValidationError.
If you have any questions or better ways of implementing let me know. Or if you don't feel comfortable pulling this in I understand. Just though it might be useful to some as it was to me.
Thanks!
Kaleb