-
Notifications
You must be signed in to change notification settings - Fork 5
fix(macos): codesign KDF with hardened runtime and timestamp #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances macOS code signing for the KDF (Komodo DeFi Framework) executable and library to satisfy notarization requirements by adding hardened runtime and timestamp options to all codesign operations.
- Updates existing Release-only codesign operations to include
--options runtimeand--timestamp=auto - Adds new codesign operations for all configurations (not just Release) with the same hardened runtime options
- Improves error messaging with additional troubleshooting instructions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/komodo_defi_framework/macos/komodo_defi_framework.podspec
Outdated
Show resolved
Hide resolved
packages/komodo_defi_framework/macos/komodo_defi_framework.podspec
Outdated
Show resolved
Hide resolved
packages/komodo_defi_framework/macos/komodo_defi_framework.podspec
Outdated
Show resolved
Hide resolved
|
Visit the preview URL for this PR (updated for commit ffa7663): https://komodo-playground--pr240-fix-kdf-signing-beek61zp.web.app (expires Wed, 22 Oct 2025 15:08:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
|
Visit the preview URL for this PR (updated for commit ffa7663): https://kdf-sdk--pr240-fix-kdf-signing-mq2hdvwh.web.app (expires Wed, 22 Oct 2025 15:07:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d |
…se double-signing\n\n- Extracted kdf_codesign helper to reduce duplication\n- Use printf for proper newline formatting\n- Sign in non-Release configs; keep post-thinning re-sign in Release\n\nRefs: PR #240 review comments
|
Fixes per review: codesign helper, newline formatting, avoid Release double-signing
|
This PR ensures KDF artifacts are properly codesigned for macOS notarization.
Available for testing in KomodoPlatform/komodo-wallet#3175
Changes:
Result:
Note
Cursor Bugbot is generating a summary for commit ffa7663. Configure here.