Skip to content

Conversation

@smk762
Copy link
Collaborator

@smk762 smk762 commented Nov 4, 2025

Closes #3346 & #3195

To Test:

  • login with trezor. confirm note is seen on initial panel as below
image
  • once logged in, hover mouse cursor over the disabled sidebar options. Confirm a note, as below, appears (except buy/sell tab should be active).
vokoscreenNG-2025-11-04_18-26-26.mp4
  • enter the buy/sell tab, and confirm it functions as expected.

@smk762 smk762 self-assigned this Nov 4, 2025
@smk762 smk762 added UX Cosmetic or flow efficiency enhancements for improved User Experience trezor labels Nov 4, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch trezor-sort-note

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 linked an issue Nov 4, 2025 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Visit the preview URL for this PR (updated for commit 59390bc):

https://walletrc--pull-3355-merge-nw9pkf3o.web.app

(expires Wed, 12 Nov 2025 09:23:20 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@smk762 smk762 changed the title chore(trezor): Add notes regarding feature compatibility chore(trezor): Unblock fiat tab, add feature compatibility notes Nov 4, 2025
@gcharang
Copy link
Contributor

gcharang commented Nov 4, 2025

@smk762 please implement the tab text (not available on trezor currently) for mobile on tap

@smk762 smk762 linked an issue Nov 4, 2025 that may be closed by this pull request
@smk762 smk762 added this to the v0.9.4 milestone Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trezor UX Cosmetic or flow efficiency enhancements for improved User Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mention trezor supports just wallet mode currently Fiat Buy/Sell tab is disabled in Trezor mode

3 participants