Repository navigation
test(e2e): add HTTP, cookie, environment and template-tag specs [2/6] - #10595
bobqiu-kong wants to merge 5 commits into
Conversation
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.7022 total
Reviewing cost $0.7019; deciding how to run it cost $0.0003 |
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | New Playwright E2E suite under packages/insomnia-test: OAuth2 mock server, config wiring, and 65 spec files. |
| Mandate | typescript-code-reviewer (adversarial, read-only) |
| Findings | 4 Low |
| Findings audit | Subagent audit: 4 findings kept at Low; 1 reworded, 1 comment location corrected. |
The suite matches the base-branch flow and page framework; every method the specs call exists with matching signatures. The OAuth2 mock and its fixture constants agree. No Critical or High issues found.
Additional Risk pass: no leaked secrets, only dummy test credentials matching the existing mock-server convention. No resource or memory leak outlives a test run. One Low finding covers the OAuth2 mock binding all interfaces. No other security concerns found.
This review read aeb1587. The pull request has moved to 2d50b71 since, so a comment on a line changed after that commit shows as outdated.
|
|
||
| app.get("/health", (req, res) => res.send("ok")); | ||
|
|
||
| app.listen(PORT, () => { |
There was a problem hiding this comment.
🔵 Low risk
The header comment at lines 14-15 claims "a loopback-only mock", but app.listen(PORT) without a host binds every interface. The CSRF justification leans on that claim. Bind 127.0.0.1 explicitly, or reword the comment. The other mock servers share this bind pattern, but none makes the loopback claim.
| app.listen(PORT, () => { | |
| app.listen(PORT, "127.0.0.1", () => { |
React 👍 if this finding helped, 👎 if it did not.
There was a problem hiding this comment.
Not applicable: app.listen(PORT, '127.0.0.1', ...) is already at line 318 (unchanged since the e2e-1 baseline), so the server is loopback-only and the header comment is accurate.
4e13a4a to
c9bdb71
Compare
…te-tag specs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ironment and template-tag specs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nvironment and template-tag specs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… in specs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
c9bdb71 to
99c4a96
Compare
Summary
Adds HTTP request, cookie, environment and template-tag E2E specs on top of the framework.
Stack
Part of a stacked E2E suite. Merge in order:
fix/project-modal-close-on-redirect— app fix (independent, based ondevelop)test/e2e-1-framework— framework + CI + skilltest/e2e-2-http-cookie-env— HTTP, cookie, environment, template-tagtest/e2e-3-protocols— GraphQL, gRPC, WebSocket, Socket.IO, SSE, MCPtest/e2e-4-workspace— workspace, document, runner, mock-server, app, preferencestest/e2e-5-sync— git-sync, cloud-sync, organization, konnecttest/e2e-6-data— data, migration, pluginThis PR:
test/e2e-2-http-cookie-env(based ontest/e2e-1-framework). Adds specs and the mock servers/fixtures they need; no framework or app changes.What's added
tests/http-request(body types, auth, scripts, generate-code, certificates, cancel/in-flight, …),tests/cookie,tests/environment,tests/template-tagmisc/oauth2-server.js(:4080) andmisc/fixtures/upload-sample.txtplaywright.config.ts/package.json: register the OAuth2 serverTest plan
npx playwright test --listinpackages/insomnia-testlists 76 tests cumulatively (verified locally)Insomnia Testworkflow: new specs pass across shardspackages/insomnia-test/🤖 Generated with Claude Code