Repository navigation
feat/option toggle prompt - #10607
Open
CurryYangxx wants to merge 5 commits into
Open
CurryYangxx wants to merge 5 commits into
CurryYangxx wants to merge 5 commits into
Conversation
CurryYangxx
added this pull request to stack #10481
October 15, 2026 07:39
CurryYangxx
marked this pull request as ready for review
October 15, 2026 07:40
CurryYangxx
requested review from
cwangsmv
and
a balanced review from Copilot
October 15, 2026 07:40
|
✅ KSAI Review: Finished
Run report (federated) · 1 paid run · $0.1973 total
Reviewing cost $0.1966; deciding how to run it cost $0.0007 |
Copilot stopped reviewing on behalf of
CurryYangxx due to an error
October 15, 2026 07:45
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
2 times, most recently
from
October 15, 2026 07:54
191d5f4 to
633810e
Compare
There was a problem hiding this comment.
| Check | Result |
|---|---|
| Scope | Global 'Clear All Response History' action across menu, renderer confirm, main-process delete; toggle heads-up alert; label renames; runner refresh on doc removal. |
| Mandate | typescript-code-reviewer (adversarial TypeScript) |
| Findings | 2 High, 1 Medium, 2 Low |
| Findings audit | One kreview:findings-auditor pass; all 5 findings upheld; 2 Low reworded; none removed. |
The clear-all path is wired correctly across renderer, IPC and main process, and the unit test covers the delete helper. The new toggle alert blocks both smoke specs that toggle the setting, so CI fails. The unlink handler hides real file failures behind a success toast.
Additional Risk pass: no leaked secrets, no new attack surface beyond the existing services.invoke bridge, no listener or handle leaks.
This review read 7032251. The pull request has moved to 633810e since, so a comment on a line changed after that commit shows as outdated.
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
from
October 15, 2026 10:50
6fd042c to
858a0a5
Compare
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
3 times, most recently
from
October 19, 2026 08:07
4da32ca to
ef21040
Compare
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
6 times, most recently
from
October 20, 2026 02:41
b75598f to
f560e3f
Compare
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
from
October 20, 2026 06:37
f560e3f to
858a0a5
Compare
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
2 times, most recently
from
October 20, 2026 07:51
b75598f to
e2b6612
Compare
CurryYangxx
force-pushed
the
feat/option-toggle-prompt
branch
from
October 20, 2026 09:16
e2b6612 to
780fc7a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two user-facing additions around the
Hide Confidential values in Preview/Consolesetting:Why
While the setting is off, confidential values are written to the local timeline and response files in cleartext. Turning it back on hides them in the UI but does not remove what was already persisted, so users need both a heads-up and a way to clean up.
Notes
canSync = false), so this only affects the local machine — no server or git state is touched.root.tsxrather thanrenderer-listeners.tsso it canrevalidate()afterwards; the response panes read from loaders, which a raw database write does not refresh. The runner history is component state, so it re-reads ondb.changesinstead.Testing
removeAllResponseHistorycovering all five document types, file unlinking, missing files, and that requests/workspaces are left alone.