Skip to content

feat/option toggle prompt - #10607

Open
CurryYangxx wants to merge 5 commits into
feat/redact-stream-responsefrom
feat/option-toggle-prompt
Open

CurryYangxx wants to merge 5 commits into
feat/redact-stream-responsefrom
feat/option-toggle-prompt

Conversation

@CurryYangxx

@CurryYangxx CurryYangxx commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

What

Two user-facing additions around the Hide Confidential values in Preview/Console setting:

  • Tools → Clear All Response History — a global clear, behind a confirmation dialog. Removes HTTP / WebSocket / Socket.IO / MCP responses and collection-runner results across every project and collection, including the body, timeline and event-log files they point at on disk.
  • Toggle notices — switching the setting back ON suggests clearing Response History; switching it OFF warns that confidential values will persist in local logs/history. Both are modals, shown on every toggle.

Why

While the setting is off, confidential values are written to the local timeline and response files in cleartext. Turning it back on hides them in the UI but does not remove what was already persisted, so users need both a heads-up and a way to clean up.

Notes

  • None of the removed document types sync (canSync = false), so this only affects the local machine — no server or git state is touched.
  • The handler lives in root.tsx rather than renderer-listeners.ts so it can revalidate() afterwards; the response panes read from loaders, which a raw database write does not refresh. The runner history is component state, so it re-reads on db.changes instead.
  • Runner results are already redacted at write time; they are included here because results recorded while the setting was off contain plaintext.

Testing

  • Unit test for removeAllResponseHistory covering all five document types, file unlinking, missing files, and that requests/workspaces are left alone.
  • Manually: clear with a request open (response pane empties), and with the Runner tab open on a past result (history list and result pane clear).

@CurryYangxx
CurryYangxx added this pull request to stack #10481 October 15, 2026 07:39
@CurryYangxx
CurryYangxx marked this pull request as ready for review October 15, 2026 07:40
@CurryYangxx
CurryYangxx requested review from cwangsmv and a balanced review from Copilot October 15, 2026 07:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

✅ KSAI Review: Finished

  1. 07:44 UTC Reading review guidelines and knowledge base before analyzing changes
  2. 07:46 UTC Tracing service invocations and IPC channels across modules
  3. 07:48 UTC Tracing settings and modal rendering paths across the codebase
  4. 07:50 UTC Tracing modal rendering and confidential redaction across UI tests
  5. 07:52 UTC Tracing modal behavior through component code and search results
  6. 07:56 UTC Tracing modal flows and reviewing smoke test coverage

Run report (federated) · 1 paid run · $0.1973 total
# Engine Result Model Turns Cost
1 opencode success glm-5.3-flash/max 88 $0.1966

Reviewing cost $0.1966; deciding how to run it cost $0.0007

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check Result
Scope Global 'Clear All Response History' action across menu, renderer confirm, main-process delete; toggle heads-up alert; label renames; runner refresh on doc removal.
Mandate typescript-code-reviewer (adversarial TypeScript)
Findings 2 High, 1 Medium, 2 Low
Findings audit One kreview:findings-auditor pass; all 5 findings upheld; 2 Low reworded; none removed.

The clear-all path is wired correctly across renderer, IPC and main process, and the unit test covers the delete helper. The new toggle alert blocks both smoke specs that toggle the setting, so CI fails. The unlink handler hides real file failures behind a success toast.

Additional Risk pass: no leaked secrets, no new attack surface beyond the existing services.invoke bridge, no listener or handle leaks.

This review read 7032251. The pull request has moved to 633810e since, so a comment on a line changed after that commit shows as outdated.

Comment thread packages/insomnia-smoke-test/tests/smoke/insomnia-vault.test.ts
Comment thread packages/insomnia-data/node-src/services/helpers/response-operations.ts Outdated
Comment thread packages/insomnia/src/root.tsx
Comment thread packages/insomnia/src/ui/components/settings/boolean-setting.tsx Outdated
@CurryYangxx
CurryYangxx force-pushed the feat/option-toggle-prompt branch from 6fd042c to 858a0a5 Compare October 15, 2026 10:50
@CurryYangxx
CurryYangxx force-pushed the feat/option-toggle-prompt branch 3 times, most recently from 4da32ca to ef21040 Compare October 19, 2026 08:07
@CurryYangxx
CurryYangxx force-pushed the feat/option-toggle-prompt branch 6 times, most recently from b75598f to f560e3f Compare October 20, 2026 02:41
@CurryYangxx
CurryYangxx force-pushed the feat/option-toggle-prompt branch from f560e3f to 858a0a5 Compare October 20, 2026 06:37
@CurryYangxx
CurryYangxx force-pushed the feat/option-toggle-prompt branch 2 times, most recently from b75598f to e2b6612 Compare October 20, 2026 07:51
@CurryYangxx
CurryYangxx force-pushed the feat/option-toggle-prompt branch from e2b6612 to 780fc7a Compare October 20, 2026 09:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants