Repository navigation
chore(sync): add id and path constraints for synced data - #10623
Draft
kwburns-kong wants to merge 1 commit into
Draft
kwburns-kong wants to merge 1 commit into
kwburns-kong wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds constraints on ids, names and paths in synced data, aligned with the matching backend changes.
Cloud sync (
insomnia-vcs,main/cloud-sync):da39a3ee5e6b4b0d3255bfef95601890afd80709.^[A-Za-z0-9_-]{1,128}$, for exampleprj_f6e7712ab6604da9a3ec744290a699ba.\, NUL, or./..segments._idandparentIdmatching^[A-Za-z0-9_-]{1,255}$.Git sync (
sync/git,main/git-service):.insomniamigration (applied all-or-nothing), git yaml imports, the legacy NeDB git client, and the legacy workspace id of a cloned repo.cloneGitRepoActionalways flushes the change buffer when it exits early.Other:
restoreBackup: the version must be a single directory name under backups.api.protocol: decoded asset paths stay within the client root.Tests: added unit tests for each constraint.
insomnia-vcstests,insomniatests, type-check and lint pass.