feat: asset browser tab shell and Assets tab on the published provider - #377
Merged
Merged
Conversation
Phase 2 of the core asset browser. The tree drawer gains a fixed
`Files | Assets` tab pair in REST mode; Files is today's tree on its
unchanged store and stays mounted while hidden, so pick -> row sync keeps
working. Outside REST mode the drawer is unchanged.
The Assets tab browses published collections as one lazily assembled
forest read through a single derived AssetView:
- @/assets/{types,projection,assetIndex,hierarchy,resolve,coverage,
orphans,freshness,spines,merge,assetView,rowFacts}: React-free, tested
under node --test (166 tests incl. a 41k-row synthetic spine).
- assetBrowserStore + a React-free loader: collection indexes merged as a
union oldest-first, subtree spines fetched once per (root, revision) on
expand, stale responses dropped on collection/scope change.
- Rows: published-at / covered-from-above / content-below badges, gap
(uncovered leaves below), dimmed only when explored, stale, and
"older tree" when a subject's hierarchy_revision predates the tree shown.
Banners for mixed resolutions, half-written revisions, unreadable
manifests and malformed keys. Orphans (removed / ahead) are listed under
the root once no unfetched spine could still hold them; until then they
are "not placed yet" with a place action.
Backend: GET /assets/index gains manifests=true, folding each revision's
delivery / provider / hierarchy_revision so the tab badges without one
fetch per subject.
Measured in Chromium on the production bundle: expanding a 41k-row spine
costs one ~70 ms main-thread task after fetch; a mode switch <= ~55 ms.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
PR Review👋 I checked your PR and found no issues. Thanks!
|
🚀 Profiling Results (Top 20 most expensive calls)
|
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of the core asset browser (Phase 1 = #371): the
Files | Assetstab shell and anAssetstab over published collections. No delivery yet — loading into the scene comes with Phase 3.What
Files | Assets.Filesis today'sTreeViewComponenton its unchanged store and stays mounted while hidden (3D pick → row sync keeps working). Notebook/websocket viewers are unchanged.@/assets/*(React-free):projection,assetIndex,hierarchy,resolve,coverage,orphans,freshness,spines,merge,assetView,rowFacts. Every badge a row shows is a pure function of oneAssetView.assetBrowserStore+ loader — collection indexes merged as a union oldest-first; subtree spines fetched lazily on expand, once per (root, revision); responses for a collection/scope the user left are dropped.gap(uncovered leaves below), dimming only for explored branches,stale,older tree(subject'shierarchy_revisionpredates the tree shown); banners formixedresolutions, half-written revisions, unreadable manifests, malformed keys. Orphans (removed/ahead) listed under the root once no unfetched spine could hold them; until then "not placed yet" with a place action.GET /assets/index?collection=…&manifests=truefolds each revision'sdelivery/provider/hierarchy_revisionso the tab badges without a fetch per subject. Opt-in; the plain fold is unchanged.assetsApiis deliberately not spread into the plugin-facingviewerApifacade (that surface arrives with plugin API 1.6.0).Verification
tscclean; seam check OK.src/frontend/src/assets,components/asset_browser, the store/loader.🤖 Generated with Claude Code