Skip to content

Conversation

@marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Jul 23, 2025

TODO

  • tests:
    • init search with small test df, see if expected results are returned in expected order
    • add, remove change functions
    • osa_distance() if works correctly
  • connect to pdoduct/activity table
  • editing of search index (add/remove/change)
  • add full query to suggestions

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher changed the base branch from beta to major July 24, 2025 09:42
@marc-vdm marc-vdm marked this pull request as draft July 24, 2025 09:44
@marc-vdm marc-vdm added the change PRs related to minor changes to AB label Sep 3, 2025
@marc-vdm marc-vdm added this to the 3.0.0 milestone Sep 3, 2025
@marc-vdm marc-vdm added the beta Issues related to the Activity Browser 3 Beta label Sep 3, 2025
@marc-vdm
Copy link
Member Author

marc-vdm commented Sep 7, 2025

@mrvisscher this is now ready for your testing, please see what you think of result sorting, autocomplete and if you manage to get errors somehow.

@marc-vdm marc-vdm marked this pull request as ready for review September 16, 2025 10:57
@marc-vdm marc-vdm requested a review from mrvisscher September 16, 2025 10:57
@mrvisscher mrvisscher merged commit f0b1d9c into LCA-ActivityBrowser:major Dec 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta Issues related to the Activity Browser 3 Beta change PRs related to minor changes to AB

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants