LibWeb/WebGL: A bunch more testsuite fixes #6744
Open
+257
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmta
reviewed
Nov 9, 2025
cqundefine
force-pushed
the
even_more_webgl_fixes
branch
2 times, most recently
from
611d6e3 to
7f96ab6
Compare
gmta
reviewed
Nov 12, 2025
konradekk
reviewed
Nov 12, 2025
Contributor
konradekk
left a comment
konradekk
left a comment
There was a problem hiding this comment.
location_handle computation is very repetitive, could it be extracted to some (inline?) function instead?
The spec mandates that a buffer during its lifetime can only get bound to either an index buffer or any other type.
The spec mandates that each uniform location object only gets used with the program it was created with.
cqundefine
force-pushed
the
even_more_webgl_fixes
branch
from
7f96ab6 to
92a2edf
Compare
Contributor
Author
Looking at how it's already pretty minimal, different between some functions and the fact that a similar pattern is already present in a lot of places I'm not sure there's any easy way to factor it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing a few more failures I found in the WebGL testsuite.