Meta: Set default preset in ladybird.py to Windows_CI on Windows #6807
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows_Experimental preset isn't tested in CI, so having the out of the box script runs using it is a bit weird.
When running on a 4k page size arm64 Linux machine, we're able to use the gn binary from the chromium CDN that vcpkg downloads automatically. This case was not checked in the script, leading to us setting the gn binary to the string 'None' if there's no gn in $PATH on such systems. Rewrite the logic for writing to the supplemental CMake file to account for None in both the gn binary path and the pkg-config binary path.
gmta
reviewed
Nov 13, 2025
| required=False, | ||
| default=os.environ.get( | ||
| "BUILD_PRESET", "Windows_Experimental" if platform.host_system == HostSystem.Windows else "Release" | ||
| "BUILD_PRESET", "Windows_CI" if platform.host_system == HostSystem.Windows else "Release" |
Collaborator
There was a problem hiding this comment.
The *_CI presets are meant to run in CI though; shouldn't we let this reflect the setup of the Linux/macOS presets and have a sane default expanded on by _CI and _Experimental?
Contributor
There was a problem hiding this comment.
Is the ENABLE_WINDOWS_CI option that is set in the *_CI presets still providing value?
4 locations using it could be replaced with ENABLE_ADDRESS_SANITIZER instead:
- https://github.com/LadybirdBrowser/ladybird/blob/master/Libraries/LibGfx/CMakeLists.txt#L147
- https://github.com/LadybirdBrowser/ladybird/blob/master/AK/CMakeLists.txt#L110
- https://github.com/LadybirdBrowser/ladybird/blob/master/Libraries/LibJS/CMakeLists.txt#L289
- https://github.com/LadybirdBrowser/ladybird/blob/master/Libraries/LibUnicode/CMakeLists.txt#L34
Then the remaining locations are:
Given these 3 locations above are not required to actually run/test the browser on Windows in its current experimental state, we could just fully disable them on Windows with FIXME's and consolidate the presets to lineup with Unix:
Windows_Experimental_Release(the default inladybird.py)Windows_Experimental_DebugWindows_Sanitizer(this is what is used in CI now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows_Experimental preset isn't tested in CI, so having the
out of the box script runs using it is a bit weird.